search

ssleptsov / ninja-keys

Keyboard shortcuts interface for your website. Working with static HTML, Vanilla JS, Vue, React, Svelte.
https://ninja-keys-demo.vercel.app/
MIT License
1.62k stars 60 forks source link

Sometimes there's no value loaded when an animationFrame is requested #34

Open jwoertink opened 1 year ago

jwoertink commented 1 year ago

This may be related to mobile browser issues, but I have about 7k bugsnag reports of this._inputRef.value is undefined and Cannot read properties of undefined (reading 'focus') which I was able to trace back to this line.

https://github.com/ssleptsov/ninja-keys/blob/52ccc0d17255832d0d7e7082d45a6f7d5e5bb8b6/src/ninja-header.ts#L124

I'm not quite sure how this part works, but my guess is maybe a guard clause is needed to ensure _inputRef exists and is the correct type?