search

ssloy / tinyraytracer

A brief computer graphics / rendering course
https://github.com/ssloy/tinyraytracer/wiki
5k stars 333 forks source link

reserved identifier violation #10

Open elfring opened 5 years ago

elfring commented 5 years ago

I would like to point out that an identifier like “__GEOMETRY_H__” does not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

ssloy commented 5 years ago

I'd say that the underscores is a minor style issue, whereas the whole file is flawed. It is written in c++98 and it should be rewritten entirely.