search

ssm-lang / sslang

A language built atop the Sparse Synchronous Model
BSD 3-Clause "New" or "Revised" License
18 stars 0 forks source link

Fix incorrect unit test case #127

Closed leoqiao18 closed 1 year ago

leoqiao18 commented 1 year ago

Incorrect type inference unit test case. There are quite a bit of style changes from brittany as well.

Interestingly, the test case still passes even after the change.

j-hui commented 1 year ago

Oh weird, why is Brittany mangling the style so heavily? It shouldn’t do that.

Can you fix the commit to only fix the test case? Let’s fix the style/figure out what’s going on in another PR.

leoqiao18 commented 1 year ago

@j-hui Judging from what is actually being styled, the original code did not look actually styled. For example, the import statement was not even aligned.

j-hui commented 1 year ago

The traceM import statement shouldn't even be there; that was left there by mistake.

I remember now; I deliberately omitted styling because it messes with the way I'm using quasiquote blocks with infix functions. I'd prefer we leave it that way for now until we figure out a good consistent style for all test cases (which may involve a little bit of refactoring, or at least shortening of the strings documenting each test case).

leoqiao18 commented 1 year ago

Reverted the style changes.