ssmkalyan / jquery-watermark

Automatically exported from code.google.com/p/jquery-watermark
0 stars 0 forks source link

JSLint would be a good idea... #52

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I'm a bit of a JSLint fiend, and would suggest you JSLint your plugin moving 
forward.

When I ran it on your plugin I got 84 warning messages.

Most are of the anal-rententive sort and formatting etc, but it's just a good 
practice and encourages best practices in coding and identifies questionable 
constructs - and is automated for building.

Also helps with minifying and keeps Doulas Crockford http://www.crockford.com/ 
- esteemed guru of Javascript from unleashing Chuck Norris to subjugate your 
code with roundhouse kicks and hurt your feelings...

Great plugin - I'm using it - after JSLinting & minifying, of course... ;-)

Don't mean to be a pedantic zealot...

Thanks,

Charlez

Original issue reported on code.google.com by charle...@gmail.com on 14 Feb 2011 at 10:45

GoogleCodeExporter commented 9 years ago
Didn't mean to post as a defect... or did I?

Original comment by charle...@gmail.com on 14 Feb 2011 at 10:46

GoogleCodeExporter commented 9 years ago
Also, just JSLinted it and got the number of warnings down to just 10, with 
just 5 uniques.

I have attached a zip with the new watermark.js and a text filr with the 
warnings - didn't want to go deeper into your code to fix...

You have a very cool plugin - be great if you incorporated this into your 
release - especially for those of us that insist on no JSLint issues and have 
an automated process of JSlinting and minifying for deployment.

Also might want to move over to GitHub for the social coding extras - 
sincethat's where the jquery guys like John Resig, Scott Gonzales, Scot Jehl, 
Filament, etc are all interacting...

All the best,

Charles

Original comment by charle...@gmail.com on 14 Feb 2011 at 11:12

Attachments:

GoogleCodeExporter commented 9 years ago
I love the plugin... jslint or not! 

Original comment by pwc1...@gmail.com on 17 Nov 2011 at 9:46