search

ssnepenthe / recipe-scraper

A library for scraping recipes from popular recipe sites.
GNU General Public License v2.0
47 stars 15 forks source link

Update epicurious scraper to not include bold list headers in ingredi… #34

Closed rpander93 closed 5 years ago

rpander93 commented 5 years ago

…ent list.

Current method seems to also include bold list sub-headers in the ingredient list. This change prevents that.

ssnepenthe commented 5 years ago

Thanks for the PR!

Do you have an example recipe I can look at where the sub headers should not be included?

It has been a while but I believe that this was an intentional decision made for recipes like this sheet cake in order to keep related ingredients grouped together.

If you look at the same recipe we are also extracting the sub headers in the instructions section.

rpander93 commented 5 years ago

Hi,

Makes sense! I created the PR originally because of [this recipe].(https://www.epicurious.com/recipes/food/views/glazed-cinnamon-cardamom-buns). I figured the results were because a design change that hadn't been incorporated into the scraper yet. But seeing there's a reason for it this PR makes no sense I think.

ssnepenthe commented 5 years ago

Sounds good.

And thanks for the linked recipe - it reveals a related issue with the current selectors.