ssnetsim / supersim

A flexible event-driven cycle-accurate network simulator
Apache License 2.0
8 stars 1 forks source link

Link time optimatization #20

Closed nicmcd closed 4 years ago

nicmcd commented 4 years ago

Previously, when SuperSim used basic makefiles, link time optimization (LTO) was shown to provide significant execution speedup. The -flto flag was used. See here: https://github.com/ssnetsim/supersim/blob/12110bdeadc77eec91f6bdc49508c3cd4c5703ff/Makefile#L48

After converting to Bazel, LTO has been unsuccessful to build. Fix it.

nicmcd commented 4 years ago

Use "--features=thinlto"

knrafto commented 4 years ago

why not put it in the BUILD file so it's used by default?

nicmcd commented 4 years ago

That would be a .bazelrc file and yes that could be added.

knrafto commented 4 years ago

oh. It can't be set via the features attribute of a BUILD rule?

nicmcd commented 4 years ago

It probably could, but why? I don't think we'd want to mandate a feature. You don't want to use LTO if you are just trying to get something to quick compile.