ssnjr2002 / stremio-gdrive

Stremio addon for fetching videos from your google drive.
101 stars 93 forks source link

Addon doesn't work with latest Stremio Android TV version #25

Closed AlyafeiAli closed 2 years ago

AlyafeiAli commented 2 years ago

Hi again, ssnjr2002!

I hope you did well in your academics.

If you're not informed, Stremio just released an Android TV version of the app and it looks really great.

However, the gdrive addon is not returning any results in the app for some reason, I can see in the logs that it does find the links and tries to send them back to the Android TV app but nothing shows up in the app.

10.1.52.7 - - [10/Aug/2022:07:40:27 +0000] "GET /stream/movie/tt5113044.json HTTP/1.1" 200 58784 "-" "-"

Apparently, it doesn't recognize the Android TV client

jaruba commented 2 years ago

we received reports about this too

@ssnjr2002 this addon fails parsing in the new stremio core because of the value set on this line: https://github.com/ssnjr2002/stremio-gdrive/blob/27f7de4fb0b52ae2d9b845233d22e1fa30dc777f/sgd/streams.py#L74

which is a string but should be a boolean value, it should be this, i think:

        self.constructed["behaviorHints"]["notWebReady"] = True

(but I haven't tested this change)

AlyafeiAli commented 2 years ago

which is a string but should be a boolean value

Oh, jaruba himself! Thank you for the tip, I've corrected the line and it's working now! And thank you for the amazing job on Stremio

jaruba commented 2 years ago

@AlyafeiAli i'm happy it's working!

jaruba commented 2 years ago

@AlyafeiAli i think it might be best to leave the issue open until it is fixed in the original repository too, otherwise the developer might not notice it

AlyafeiAli commented 2 years ago

@AlyafeiAli i think it might be best to leave the issue open until it is fixed in the original repository too, otherwise the developer might not notice it

Oh right, good point. Thanks again :)

ssnjr2002 commented 2 years ago

Thanks @jaruba for the fix and thanks @AlyafeiAli for bringing the issue to light and testing the fix 👍

AlyafeiAli commented 2 years ago

And thank you for the amazing addon, @ssnjr2002 ♥️