search

ssocratous / intro-data-capstone-biodiversity

0 stars 0 forks source link

Nice pie chart! #2

Open asadmehdi785 opened 6 years ago

asadmehdi785 commented 6 years ago

I really liked your inclusion of a pie chart when looking at the percentage of each species that was protected based on the data. Although it was a bit incomplete (the pie chart did not go all the way around), it was a nice additional visualization, and you definitely went above and beyond there! Great job with that.

Just one little thing about the code for that part:

https://github.com/ssocratous/intro-data-capstone-biodiversity/blob/b4b62681f63c25c067e561b782b5c5f8e73160c1/Capstone%20Option%202%20Biodiversity%20for%20the%20National%20Parks/Capstone%202%20biodiversity.py#L230

Here, while doing plt.show without including the parentheses will probably work in most cases, it is better practice to do plt.show() (notice the parentheses). This will guarantee that it will work in all cases. This is actually how we want to be calling all functions in python; the inclusion of the parentheses is really important and will help prevent unexpected behavior in our code.

ssocratous commented 6 years ago

Thanks Im not sure what hsppen to the pie chart!

Thanks for your comments re plt.show.

My fault on this for some reason I omitted the parentheses.