search

ssokolow / nodo

Pre-emptively created repository so the design can be discussed on the issue tracker before commits are made (repo name may change)
Apache License 2.0
18 stars 0 forks source link

Bump toml from 0.5.10 to 0.7.1 #10

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps toml from 0.5.10 to 0.7.1.

Commits
  • 9a80a78 chore: Release
  • e90b292 chore: Update release process
  • 410ee66 docs: Update changelog
  • 03bd127 Merge pull request #502 from robjtede/doc-features
  • f2e6c0e docs(toml): display feature guarded items on docs.rs
  • 2d728d4 docs(toml-edit): display feature guarded items on docs.rs
  • 5df84a5 docs(toml-datetime): display feature guarded items on docs.rs
  • 08ad143 docs(serde-spanned): display feature guarded items on docs.rs
  • 55d44e7 docs(toml): Point people to 'toml_edit'
  • 57c9bb0 chore: Release
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
NobodyXu commented 1 year ago

toml 0.7.1 actually uses toml_edit as its implementation, so probably better to just switch to toml_edit.

ssokolow commented 1 year ago

From what I remember, using toml_edit directly would lose the Serde support I chose toml for.

I'll have to double-check that before I make a decision, and I'm about to go to bed and then into a busy few days, so it could take until as late as Saturday before I get around to that.

NobodyXu commented 1 year ago

From what I remember, using toml_edit directly would lose the Serde support I chose toml for.

toml_edit has a feature flag serde for enabling serde support. toml actually directly uses the serializer/deserializer defined in toml_edit.

cargo-binstall, the other projects which I am one of the maintainers, switch from toml to toml_edit recently and it only requires changing toml to toml_edit::de::from_str, toml_edit::ser::to_string and swapping the error types.

I'll have to double-check that before I make a decision, and I'm about to go to bed and then into a busy few days, so it could take until as late as Saturday before I get around to that.

No problem.

ssokolow commented 1 year ago

Done. toml_edit is now used directly.