ssokolow / quicktile

Adds window-tiling hotkeys to any X11 desktop. (An analogue to WinSplit Revolution for people who don't want to use Compiz Grid)
https://ssokolow.com/quicktile/
GNU General Public License v2.0
878 stars 79 forks source link

heisenbug in monitor-switch on a window entirely outside the target monitor's bounds #109

Closed ssokolow closed 1 year ago

ssokolow commented 4 years ago

While doing my final tests for pushing 0.4.0 to master, I managed to trigger an edge case I hadn't considered before and, like an idiot, I forgot to save the crash log because I thought it would be easy to re-create.

It involves an uncaught None inside WindowManager.reposition when clipped_rect is None because the window's position relative to the current monitor is outside the dimensions of the target monitor, but I can't seem to reproduce it and I can't see how it would get past the checks.

Specifically, it involves triggering the uncaught exception handler when None should just trigger a safe "do nothing" code path.

As I can't reproduce this, I'm leaving it open as a reminder to myself to investigate further, but not letting it block 0.4.0.

ssokolow commented 4 years ago

Removing the "needs more info" because, in hindsight, without Bugzilla's support for indicating who it's waiting on, it's counterproductive to "needs more info" yourself.

ssokolow commented 1 year ago

With the current state of the codebase, I don't see how this could be possible anymore.