search

ssokolow / quicktile

Adds window-tiling hotkeys to any X11 desktop. (An analogue to WinSplit Revolution for people who don't want to use Compiz Grid)
https://ssokolow.com/quicktile/
GNU General Public License v2.0
860 stars 78 forks source link

Uncaught exceptions in tiling commands stop future hotkey presses from registering #111

Closed ssokolow closed 11 months ago

ssokolow commented 4 years ago

When I encountered #109 and chose the "Close" button in the exception dialog, I found that QuickTile no longer responded to hotkeys.

Given how difficult it is to trigger an exception, that I was unable to reproduce #109, and that QuickTile on GTK 3.x has already taken so long, I don't want this to block releasing of 0.4.0 but, for a later release with a more developed automated functional test harness, I need to rework command dispatch so that it can catch any exceptions, manually invoke the GUI exception handler, and then return success to the event-handling code to prevent the event from being unhooked.

ssokolow commented 11 months ago

This should be fixed by commit 27804d2428273522387a86add5d771025e850fa3.