search

ssokolow / quicktile

Adds window-tiling hotkeys to any X11 desktop. (An analogue to WinSplit Revolution for people who don't want to use Compiz Grid)
https://ssokolow.com/quicktile/
GNU General Public License v2.0
861 stars 78 forks source link

Fixed using uninitialized variable #57

Closed mputz86 closed 8 years ago

mputz86 commented 8 years ago

Replaced the access to the unused variable mmask with the state of xevent. This bug crashed my quicktile after a while :).

ssokolow commented 8 years ago

Thanks. I've been meaning to give this a proper audit and test suite for ages but other, more important things keep coming up. (At the moment, I'm working on my degree project.)

mputz86 commented 8 years ago

No need for excuses :) - quicktile works pretty good for me, I really like it and have not stumbled over any other problem yet.. . So, first things first: Good look for your degree project! :)

ssokolow commented 8 years ago

Thanks. :)

...but it's actually not intended as an excuse. I have a bit of a problem with obsessive perfectionism and a test suite with 100% branch coverage is something I hope to eventually retrofit to all of my creations.

(It's one of the reasons I've been meaning to get into programming Rust. The compile-time checks greatly reduce the chance I'll burn out chasing my own standards through test suites.)