search

ssokolow / quicktile

Adds window-tiling hotkeys to any X11 desktop. (An analogue to WinSplit Revolution for people who don't want to use Compiz Grid)
https://ssokolow.com/quicktile/
GNU General Public License v2.0
869 stars 78 forks source link

Fix left/right using edge cycle steps #81

Closed avaly closed 7 years ago

avaly commented 7 years ago

I believe that the left and right positions should be using the edge_steps for cycling. Feel free to close otherwise.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 40.902% when pulling 069be7aa3874ad541b3295fdc03e99c93a4a9e29 on avaly:fix/left-right-edge into f72b23bbf7b644906d15c49d02b2e9c71b0d001f on ssokolow:master.

ssokolow commented 7 years ago

That would really mess up the cycling presets which QuickTile copied from WinSplit Revolution.

corner_steps is used for things which should start at 1/2 width, then cycle to 1/3rd and then 2/3rds, aligned to one of the sides.

edge_steps is used for things which should start at full width, then cycle to 1/3rd and then 2/3rds, center-aligned.

The intent being that the left and right presets behave the same as the corresponding corner presets, but just twice as tall.

Among other things, your pull request would cause the first press on left or right to produce results identical to middle.

However, I'll consider renaming edge_steps so this kind of suggestion is more obviously wrong.

ssokolow commented 7 years ago

There. I've renamed edge_steps to middle_steps and corner_steps to edge_steps to make their meanings more intuitive.