ssolovey / ecp

ECP - Ecommerce project based on Magento
Open Software License 3.0
1 stars 0 forks source link

warranty bug #323

Closed ssolovey closed 9 years ago

ssolovey commented 9 years ago

Commwar If populated AND "Commercial Applic" is checked AND "Commwarval" is less than "Basewarval", "Commwar"overrides Basewar from Customer file

[Customer] “-Commercial warranty box: warranty should only change to 18/100 if the customer profile indicates a warranty higher than that for their standard. i.e. 12m/12K standard should not change to 18/100K.”, it is follows the logic highlighted in yellow above.

ssolovey commented 9 years ago

I clarified today regarding this point. Our current implementation is almost correct. The only thing required to be done is to filter dropbox in case of commercial application.

See example: We have something like 6/6, 12/12, 18/18, 36/36 in case commercial application is NOT set In case it SET we should set value to 18/18 and in dropbox have 6/6, 12/12, 18/18 (everything higher 18/18 should be removed)

It means that we allow to downgrade warranty but no upgrades.

And dropbox is still required. The link to the warranty document should be on the right of the dropbox. It will be single document for all warranties so no logic here just static link with always the same reference to some pdf document.

SkyLark commented 9 years ago

So, this is actually the logic that we had implemented. I need to add just a link to document when it will be availabe.

ssolovey commented 9 years ago

and also to remove unneeded items in dropbox when commercial application is checked.

SkyLark commented 9 years ago

Just one clarification about current implementation:

  1. we have these values 6/6, 12/12, 36/36 for Com App not selected state;
  2. we have these values 6/6, 12/12, 18/18 for Com App selected state;

The idea is that 18/18 is a Base warranty value for Product and 36/36 is a base warranty value for Company. We could show only one base warranty at a time according to Com App checkbox status. (current implementation)

OR, I need to show all possible warranties? Company , Product and Additional ???

ssolovey commented 9 years ago

In case 1, everything lower 36/36 In case 2, everything lower 18/18

Can you tell me also the list of: Company Product Additional

for this specific case? I just want to understand what's the values for each categories separately. Thanks

SkyLark commented 9 years ago

6/6, 12/12 - additional

18/18 - Product

36/36 - Company

while com app check box checking we just exchange tha base warranty values from Product and Company

ssolovey commented 9 years ago

Thanks! please use this rule: In case 1, everything lower 36/36 In case 2, everything lower 18/18

So additional are also included It should look like this: case 1: 6/6, 12/12, 18/18, 36/36 (36/36 selected by default) case 2: 6/6, 12/12, 18/18 (18/18 selected by default)

SkyLark commented 9 years ago

DONE.

Note: In other case when company's warranty value is less than product and additional warraties the drop box would have only Company's Base Warranty Value

Waiting for warranty document.

ssolovey commented 9 years ago

Open point: we need pdf-documents for warranties?

SkyLark commented 9 years ago

Is there any update?

ssolovey commented 9 years ago

not ye but they promised to provide. I'll ping them in 5-6 days.

ssolovey commented 9 years ago

feedback from customer: No PDF warranty documents with links needed anymore.