ssolovey / ecp

ECP - Ecommerce project based on Magento
Open Software License 3.0
1 stars 0 forks source link

Shipping recalculation in Order page #342

Closed SkyLark closed 8 years ago

SkyLark commented 8 years ago

CUSTOMER:

  1. User changes ZIP code
  2. We should stay on the same page but shipping preloaded would popup (NO button but automatically on change)
  3. As soon as info is loaded, preloaded is closed and corresponding fields are updated in order form

I think it should be enough. Right?

For other comments please reference issue https://github.com/ssolovey/ecp/issues/321

SkyLark commented 8 years ago

The feature is added.

Implemented changes:

  1. When the use enter a new ZIP value and it validated as valid one the Shipping calculation started.
  2. After the recalculation the State filed is updated with the new label according to ZIP value
  3. The Hidden Form inputs also updated;
  4. If the ZIP from Wisconsin state the Tax value is updated and the Product total price also recalculated.
  5. If the ZIP value is not valid the ZIP input marked with red border.
  6. Some minor bugs fixing and some code organization

Total time spent on Issue 4 hours

ssolovey commented 8 years ago

Found some bugs: Try T280854 when put 20175 or any other zip codes and try to make an order

Bug 1: If I select text in destination ZIP field and try to enter new one nothing happens. I have to erase the text and then enter new one. However it should work as in regular field: text is selected and if you start typing new one you'll get these numbers in that field.

Bug 2: Enter 48331 in ZIP and State will be automatically switched to Michigan. That is correct. If I check "Same as Sold To" information is copied but NOT state and zip. They should be copied also. You will see also that city is Chicago and it is Illinois but in State and zip field it remains unchanged but this is I believe side effect. I double checked in company profile and zip and state is available in address so we should copy it also but only in case "Same as Sold To" was checked.

Bug 3: Please check company "SKYTEST": It has Address 1 and Address 2 but on order page we have only value from Address 1. This order will never get to addressee as address is incomplete. We have either to add Address 2 on order page or do Address = Address 1 + " " + Address 2

SkyLark commented 8 years ago

Comment on Bug 2:

In this case I would need to start shipping recalculation again as the zip value changed. The price and other fields could change. Is it OK? If yes I would need to add this feature.

ssolovey commented 8 years ago

Bug 2: yes, that's OK.

SkyLark commented 8 years ago

Bug 1 - fixed

SkyLark commented 8 years ago

Add address 2 to order page Bug 3 fixed

SkyLark commented 8 years ago

for Bug 2 we need to wait until shipping service will be available

SkyLark commented 8 years ago

UPDATE

Use case 1

If user activate checkbox then copy everything from use profile including State and zip code. We should simply overwrite what was entered on product page.

Use case 2 If user changes the state just remove previous zip code so user will enter the new one. But only in case state is really changed. If user opens dropbox and selected the same state as before then keep value in ZIP field unchanged.

If you want to discuss this, we can try to set the call tomorrow.

I think these scenarios should be easy to implement and should be intuitive for user.

SkyLark commented 8 years ago

Use case 2 - implemented

SkyLark commented 8 years ago

Use case 1 - implemented

@ssolovey Please play around with the Ship To inputs and shipping re-estimation. I think you will find more usecases that could be covered.

I leave this task open before you test and approve it.

SkyLark commented 8 years ago

Recalculation implemented