sspiff / lms-plugin-pyrrha

Pyrrha - Daughter of Pandora
GNU General Public License v2.0
13 stars 4 forks source link

inconsistent track volumes with v0.5.0 #37

Closed sspiff closed 4 months ago

sspiff commented 4 months ago

Multiple reports on the forum of inconsistent track volumes with v0.5.0.

Could be because trackGain() was changed to use playingSong instead of streamingSong. It looks like, for the purposes of identifying the gain to actually be used during playback, trackGain() is called (just once) when the previous song is still the playingSong.

trackGain() is also called periodically during playback (every 10 sec or so) as part of a status query, but perhaps the gain returned at this time is for display/informational purposes only and does not affect actual playback volume.