sspiff / lms-plugin-pyrrha

Pyrrha - Daughter of Pandora
GNU General Public License v2.0
13 stars 4 forks source link

wrong station plays #39

Open sspiff opened 4 months ago

sspiff commented 4 months ago

When selecting a station from the station list, occasionally the station above (or below?) the selected one will play instead.

See https://forums.slimdevices.com/forum/user-forums/3rd-party-software/1675996-pyrrha-pandora-s-daughter?p=1698787#post1698787 and https://forums.slimdevices.com/forum/user-forums/3rd-party-software/1675996-pyrrha-pandora-s-daughter?p=1699423#post1699423

sspiff commented 1 month ago

More discussion: https://forums.slimdevices.com/forum/user-forums/3rd-party-software/1675996-pyrrha-pandora-s-daughter?p=1719418#post1719418

sspiff commented 1 month ago

Reproduction steps:

  1. Browse to the Pyrrha station list.
  2. From another device or browser window, change the station sort order in the Pyrrha settings.
  3. Back in first device/browser, play a station.

Assuming the selected station is not in the same place in the new sort order, the wrong station will play.

sspiff commented 1 month ago

Based on its use in this file, maybe a value key is needed for each list item to uniquely identify it?

https://github.com/LMS-Community/slimserver/blob/public/9.0/Slim/Formats/XML.pm