search

sspinc / terraform-provider-credstash

Terraform provider for secrets stored with credstash
MIT License
68 stars 35 forks source link

AWS_PROFILE support #7

Closed asafdav closed 7 years ago

asafdav commented 7 years ago

First of all, thanks for this amazing terraform provider! In our use case, we have different credstash instances spread over different accounts, I had to add profiles support and I think that other people can benefit from that.

It should solve #3

asafdav commented 7 years ago

@tmichel thanks for the quick workaround.

  1. I think that the build fails because of this import https://github.com/asafdav/terraform-provider-credstash/blob/e16edd4ae6d111053cb6ff749982d82a71052edd/datasource_secrets.go#L10 instead of fetching my updated version of "credstash" it takes your original one, I forked the entire project and changed it to asafdav/* and it worked
  2. I can squash my commits but it's not needed you can squash the PR when you merge it using Github, isn't it cool ? screen shot 2017-07-16 at 14 32 26
tmichel commented 7 years ago

Cleaned up the code (gofmt) and pushed to master: 2433b14.

Thanks again!