`using namespace something;`

ssriram1992 / EPECsolve

Code to compute mixed-equilibrium in linear EPECs

https://ssriram1992.github.io/EPECsolve/html/index.html

GNU General Public License v3.0

6 stars 2 forks source link

`using namespace something;` #32

Closed ssriram1992 closed 4 years ago

ssriram1992 commented 4 years ago

Please refrain from using namespace something in a header file. It brings the specific namespace to global namespace for the user also, thus defeating the whole purpose of namespaces at all! I saw multiple places with

using namespace std;
using namespace Game'

etc. Please remove all such usages. For example, you should not have been able to write vector<short int> encoding; in include/algorithms/outerapproximation.h.

gdragotto commented 4 years ago

Sure. It's again because of code consistency with the old codebase.

ssriram1992 commented 4 years ago

What code consistency, sorry? The old one did not have any using namespace something in the headers. There were, if at all, only in .cpp files (which is okay now too).

gdragotto commented 4 years ago

For better code readability, fixed in 52f1445.