ssrwpo / ssr

SSR - Router with SSR for Node & Meteor
https://ssrwpo.github.io/ssr/
MIT License
93 stars 16 forks source link

Tracker is not defined #1

Closed blntylmn closed 7 years ago

blntylmn commented 7 years ago

Hi, good job! Everything seems to work but I'm getting this error on the browser console.

screen shot 2017-01-25 at 13 45 29

cbilotta commented 7 years ago

Hello ! Can you send me the code where you use Tracker ?

blntylmn commented 7 years ago

Don't know. This is just your demo project :)

cbilotta commented 7 years ago

Have you run meteor yarn install on both the root folder and the demo folder ? You need to do it in both for the demo to work!

blntylmn commented 7 years ago

"meteor yarn install" gives me an error like this -'yarn' is not a Meteor command. See 'meteor --help'. So I run just "yarn install" both of them ( root an demo folder).

cbilotta commented 7 years ago

You need to install it first. Meteor npm i -g yarn

blntylmn commented 7 years ago

it was my fault then :( After a long time I returned to the meteor. So I didn't know I have to install separate "yarn" for meteor. So here is the steps what I did.

ATTEMPT ONE 1) "meteor npm i -g yarn" 2) "meteor yarn install" for both folders (root & demo) 3) run with "meteor" again 4) nothing changed error was still there FAILED

So I thought maybe something gone wrong at the first install without meteor part "yarn install".

ATTEMPT TWO 1) "re clone" the repo for clean install 2) "meteor yarn install" for both folders (root & demo) 3) run with "meteor" again 4) nothing changed error is still there FAILED screen shot 2017-01-25 at 14 39 16

PEM-- commented 7 years ago
meteor --settings ./settings.json
PEM-- commented 7 years ago

Package order issue, I've circumvented it by forcing the load order of mongo and tracker at the package level. I've also updated the docs for running the demo with the settings.

I'm publishing a 1.4.1 in case that would happen on my production projects. Deployments could suffer from these cases.

Thanks for reporting this issue.

blntylmn commented 7 years ago

Yeap. Worked in 1.4.1. Btw it is painful writing "meteor --settings settings.json" everytime. What about this : screen shot 2017-01-25 at 15 20 53 and then just "yarn meteor"

PEM-- commented 7 years ago

OK, I get it and succeed to reproduce it.

When Meteor dev tools is opened and you load the App, meteor-devtools is crashing. This is the reason why you got an error at the VM and neither at the package level nor the demo level.

If you start a new tab, load the app and, only then, you go in the meteor-devtools, meteor-devtools doesn't crash anymore.

Note that despite having an issue reported by meteor-devtools, the demo and the package are still working. Chrome isolates the error.

For your suggestion, that would be a nice 1st contribution and with an update on the README, it would be very welcomed.

PEM-- commented 7 years ago

See https://github.com/bakery/meteor-devtools/issues/61

PEM-- commented 7 years ago

@blntylmn I'm closing the issue as there's nothing more to say about it.

blntylmn commented 7 years ago

Ok I also noticed when the console is closed there is no issue. Thanks anyway. I made a pull request for reducing the application start code.

PEM-- commented 7 years ago

Actually, the demo doesn't use Tracker at the time being. @iRayzer or me will add a reconciliation based on pub/sub as an example in the demo. The case will disappear 😉