search

ssrwpo / ssr

SSR - Router with SSR for Node & Meteor
https://ssrwpo.github.io/ssr/
MIT License
93 stars 16 forks source link

Make react-intl optional #61

Open s7dhansh opened 7 years ago

s7dhansh commented 7 years ago

Is there a proper way to do it? From the looks of it, it seems embedded deep in the code. I can easily remove i18n but not react-intl/react-intl-redux

Basically with Meteor 1.5, bundle-visualizer shows intl packages to be taking almost 59% (1.4mb) of a small app.

I also saw https://ssrwpo.github.io/ssr/i8n/ but to no fruitful avail.

PEM-- commented 7 years ago

Nice found. A PR would be great. I'm changing the title to a less confusing meaning as this is the develop branch.

s7dhansh commented 7 years ago

Will try. But I am not familiar with the code-base at all. Some basic pointers would be helpful. As in why do you use it (what kind of messages and at what steps).

From the code, I feel just changing the Provider to be taken from react-redux instead pf react-intl-redux should do the trick. The other intl related files are the reducers and actions, which appear to be harmless. Though, we should make them optional somehow.

cbilotta commented 7 years ago

Can you give me an email address so I can invite you to slack

s7dhansh commented 7 years ago

sudhansh AT gmail

cbilotta commented 7 years ago

Have you received my invitation ? Use it for basically anything - But try to talk in private if you get caught up in needing explanations instead of spamming the general channel :)

s7dhansh commented 7 years ago

Yes I have. Thank you. I will try to get my doubts cleared on Monday. Weekends are quite hectic for me :)

sakulstra commented 7 years ago

@s7dhansh is there any progress on this? can i somehow help? - i tried your simple approach (replacing the provider) and for me it seems to work (but i'm not sure if it won't break for intl users)

s7dhansh commented 7 years ago

@sakulstra Sorry no. I did not get enough time to do this. For now I use my own fork where I just remove everything. Not ideal, just works for me now as I do not need intl. You may get cues here https://github.com/settlin/ssr/tree/settlin.

cbilotta commented 6 years ago

Updates on this ?