search

ssrwpo / ssr

SSR - Router with SSR for Node & Meteor
https://ssrwpo.github.io/ssr/
MIT License
93 stars 16 forks source link

Q: Do I need moment and lodash? #67

Closed s7dhansh closed 7 years ago

s7dhansh commented 7 years ago

They are peer dependencies, and removing them does not seem to give any obvious error. Hence I was wondering, if they are required for this package to work properly?

cbilotta commented 7 years ago

I will check on that briefly!

cbilotta commented 7 years ago

We do use lodash. However, I didn't see any use of moment in the develop branch. Maybe you can make a pull request ? Thanks!

s7dhansh commented 7 years ago

https://github.com/ssrwpo/ssr/pull/71

moment is only used in demo. lodash is also used only in a couple of shared functions createHandleSubscribe and createHandleSyncViaMethod. I am not getting any error as I am not using these two. I think we can skip lodash as well, to reduce the bundle. Or use lodash.debounce and lodash.omit.

cbilotta commented 7 years ago

Lodash is used by the package in createRouter