ssshake / vintage-computer-wifi-modem

TheOldNet.com WIFI Modem Emulator
GNU General Public License v3.0
82 stars 15 forks source link

Add a "passthrough" mode for unimplemented AT commands #8

Closed jonthysell closed 2 years ago

jonthysell commented 3 years ago

Some software tries to call Hayes commands that aren't implemented, but really don't apply to the device anyway. See issue #7.

Rather than having to implement every (potentially no-op) command, what if there was a mode that, when enabled, just checked if the command starts with AT just always returned OK. You could add it as a final else-if statement when you're checking the command string.

It might mean that the software sending the commands is expecting some different behavior, but for no-op things (like changing the "speaker volume") it might broaden the compatibility.

ssshake commented 3 years ago

Great thanks for the submission. I'll do it when I get time or if you know how to change it yourself please do so and submit a PR!

ssshake commented 2 years ago

This is fixed now and please look at the new main repo for this project under The Old Net org: https://github.com/TheOldNet/vintage-computer-wifi-modem