search

ssssota / svelte-exmarkdown

Svelte component to render markdown.
https://ssssota.github.io/svelte-exmarkdown
MIT License
177 stars 6 forks source link

Fix Katex SVG symbols not rendering namespace issue #140

Closed jacokok closed 8 months ago

jacokok commented 8 months ago

This is to resolve Katex SVG render issues caused by invalid namespace for SVG components.

It will add the below to components of svg and path type to resolve render issue.

<svelte:options namespace="svg" />

Resolves: https://github.com/ssssota/svelte-exmarkdown/issues/123

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: 08b5f994b3902ab68da369f030b494c456a8b61c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | svelte-exmarkdown | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dd8c3eb) 98.72% compared to head (0ecddb7) 98.83%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #140 +/- ## ========================================== + Coverage 98.72% 98.83% +0.10% ========================================== Files 7 9 +2 Lines 235 257 +22 Branches 37 38 +1 ========================================== + Hits 232 254 +22 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jacokok commented 8 months ago

Updated tests to include new Element node. Added two new tests to check if correct element is getting rendered.