Open GoogleCodeExporter opened 9 years ago
Thanks for your contribution.
I can not say for the rest of the changes, but I would prefer if the
authentication properties stay copied instead of retained:
-@property (nonatomic, copy) NSDictionary *authenticationProperties;
+@property (nonatomic, retain) NSDictionary *authenticationProperties;
This is a very small object, so copying it is no performance or memory issue.
On the other hand this will ensure that once set no one will interfere with the
rest of the authentication logic (e.g. bugs in the rest of the application will
not have impact on the generated code).
Regards
Original comment by pmilosev
on 4 Oct 2011 at 12:05
It may have had something to do with me altering authentication credentials
*after* the containing object was created or something (and then propagate the
changes that use those same credentials to other connections). But it is all a
bit hazy now. That change was one of the less memorable for me after looking at
the changes.
You're welcome to drop them, it is a minor change.
Original comment by lailo...@gmail.com
on 5 Oct 2011 at 1:06
Original issue reported on code.google.com by
lailo...@gmail.com
on 16 May 2011 at 7:48Attachments: