Closed danielbush closed 3 months ago
@thdxr @fwang @jayair is there anything we could do to help get this change into sst
?
gonna have conflicts if we #266 both have different docs right
gonna have conflicts if we #266 both have different docs right
I'm happy for the maintainers to pick one (assuming they're happy for this feature to be added) so long as they
I haven't added anything to add additional ad hoc IAM permissions. That would be a nice additional fieature.
This PR is just adding vpc
as a config and then if it's set, adds the IAM needed to connect to the VPC. (Not sure if I can reduce those a bit more).
I'll ping Frank
Thanks @danielbush!
In v0.0.324, u can set vpc like this — https://ion.sst.dev/docs/component/aws/nextjs/#vpc
Add
vpc
configuration option tosst.aws.Nextjs
so that the server code in next.js can access resources in the vpc, see #261 .eg
I've tested this by building
sst
binary (usinggoreleaser
etc) on this branch and deploying it to our dev environment. The next.js server code needs to hit elasticache through our vpc. I've checked in AWS to verify the VPC for the "default" lambda running next js and its execution role were updated with the permission.There's another P/R from @kane50613 #266 . We were both wanting to get this to happen.