search

sst / ion

SST v3
https://sst.dev
MIT License
2k stars 234 forks source link

Generated typescript files should not be excluded from git #271

Closed JanStevens closed 5 months ago

JanStevens commented 5 months ago

Hi,

When you want to for check typescript and ESlint rules in CI PR branches you quickly end up in the situation that you first need to deploy your app in CI before the types are generated. For PR this is not really ideal since you don't want the changes to be applied directly (hence the PR).

An option would be to generate the types in userspace (ex: sst.types.ts), indicating that the files should not be edited and always overwritten, this way they can be committed and CI can run.

Regards

thdxr commented 5 months ago

yeah we need to think about this more - maybe it does make sense to check in the generated code

i was thinking about adding a codegen field in the config to allow specifying additional places to output code (and support other languages like go)

thdxr commented 5 months ago

we reworked where these get generated so you can handle however you want - try 0.0.343