sst / ion

❍ — a new engine for SST
https://ion.sst.dev
MIT License
1.11k stars 131 forks source link

Email Fix: Throw Error when DNS is set but not a Domain #344

Closed san4d closed 2 months ago

san4d commented 2 months ago

This change adjusts the conditional checks for the AWS Email construct to match the error message:

The "dns" property is only valid when "sender" is a domain

This came up while I was attempting to verify a domain:

export const emailDomain = new sst.aws.Email('Domain', {
    sender: 'my.sub.domain',
    dns: sst.aws.dns({ zone: rootZone.id }),
})
fwang commented 2 months ago

Thanks @san4d! Nice catch 👍