search

sst / ion

❍ — a new engine for SST
https://ion.sst.dev
MIT License
1.07k stars 118 forks source link

WIP: add false option to functions #482

Open yyaskriloff opened 4 weeks ago

yyaskriloff commented 4 weeks ago

fixes issue #479

I added the option to make logging false. I'm very unfamiliar with Pulumi so I hope this doesn't create more of a hassle than it solves.

I allowed args.logging to be false then if args.logging is false then normalize logging returns early which then doesn't create a log group with makes loggingConfig false when creating function

fwang commented 4 weeks ago

@yyaskriloff Lambda will always create a log group for each function. Can you clarify what you are trying to do and share your use case?

yyaskriloff commented 4 weeks ago

My apologies I miss understood. I didn't know lambda automatically created a log group. I guess what I'm looking for is the ability to disable the cloudwatch logs by removing the access role from lambda as to not duplicate my logs if I'm using a third party for log monitoring. In that case this PR can be closed because the code I wrote is far from accurate.

I thought that SST was just don't give you the option not to create not knowing that's the default.

Sending AWS lambda logs to Axiom

yyaskriloff commented 4 weeks ago

Would adding an explicit deny statement accomplish this?