Fix tags cache - Githubissues

sst / open-next

Open source Next.js serverless adapter

https://open-next.js.org

MIT License

3.73k stars 112 forks source link

Fix tags cache #317

Closed conico974 closed 7 months ago

conico974 commented 8 months ago

This PR should fixes 2 issues from using revalidateTag

A regression was introduced in #295 which made tags not being generated at build time for any route
fetch cache is never read on next@14+, they changed the interface again

This PR also adds a test for revalidateTag

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: b2d53e85bc49e37770041beea70d9d3100c3306e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

| Name | Type | | ---------------- | ----- | | open-next | Patch | | app-pages-router | Patch | | app-router | Patch | | tests-unit | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
open-next	❌ Failed (Inspect)			Nov 28, 2023 9:28pm

sladg commented 8 months ago

Considering no change in package.json in lock file update correct/expect?

conico974 commented 8 months ago

Considering no change in package.json in lock file update correct/expect?

Yes and no, I had to update next for the e2e tests. I'll push a change to pin next to 14.0.3 in package.json, we already install latest during e2e so it's fine