search

sst / open-next

Open source Next.js serverless adapter
https://open-next.js.org
MIT License
3.7k stars 111 forks source link

Not use custom-resource converter for dynamodb seeding adapter #365

Closed fwang closed 4 months ago

fwang commented 4 months ago

Currently OpenNext the adapter for seeding the dynamodb table accepts a CloudFormation custom resource event.

This change makes the adapter take a Lambda invoke event. I think it makes sense to decouple how the Lambda function is deployed.

In the case of a CloudFormation deployment, the custom resource would invoke this function.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 90f93832deff7f65fce552f7eb763bee44049af3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 5:31pm