search

sst / open-next

Open source Next.js serverless adapter
https://open-next.js.org
MIT License
3.7k stars 111 forks source link

Fix incorrect 200 with wrong buildId #397

Closed conico974 closed 3 months ago

conico974 commented 3 months ago

When requesting data for page dir with an incorrect BUILD_ID, we should return 404 with {} as the body.

This could cause some 500 on new deployment for page router, since running client could request data with the old BUILD_ID

Links to the discord thread : https://discord.com/channels/983865673656705025/1217895314741006387

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: c538ea1a5e79584e164ec07e6bcc5b9583765e0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ---------------- | ----- | | open-next | Patch | | app-pages-router | Patch | | app-router | Patch | | tests-unit | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 11:26am