OpenNext V3

[conico974]

This PR is for OpenNext V3.

There is one remaining thing that may still need some changes it's the experimentalBundledNextServer options that is broken in Next 14.2 and it might be hard to make it work again. There is 2 way to handle this, we could just deprecate the options ( maintaining this could become an absolute nightmare), or we could keep it as is (it's experimental after all) and fix it for new versions when we get time.

One other things is that the e2e tests uses a custom CDK implementation, we may want to move to Ion, or we could keep the cdk implementation as some sort of reference implementation. (this is probably something we can do later)

I know that this will be very hard to properly review such a big PR, feel free to ask if you need some information on anything either here or on discord.

Last things, i think we should not squash merge this PR, and we probably want to manually edit the changelog in the Version Packages PR as well.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 52641c1fdfea25b398523d4df1db5f3b67c0ace1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

| Name | Type | | ---------------- | ----- | | open-next | Major | | app-pages-router | Patch | | app-router | Patch | | tests-unit | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
open-next	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 3, 2024 1:16pm

[khuezy]

Nice! There's a lot to review and I'll likely miss a bunch.

[conico974]

Nice! There's a lot to review and I'll likely miss a bunch.

Yeah don't worry, worst case scenario we can still fix things later if needs be. We need to stop having 2 separate versions of OpenNext, it's becoming a pain to manage. I've given up doing rebase in V3, because it was too much work to rebase like 80 commits every time. Also a lot of the issues in the repo can be solved by using V3.

[conico974]

@khuezy I think i have to do a squash merge actually. The main branch is protected against merge commits. But it should be fine i've tested locally and there is no issue and we still get the history in the PR

[khuezy]

That should be okay, nice work! SHIP IT :shipit:

[conico974]

Ok let's go, let's hope i didn't mess the e2e tests