sst / open-next

Open source Next.js serverless adapter
https://open-next.js.org
MIT License
3.7k stars 111 forks source link

fix 404 when no route match at all #426

Closed conico974 closed 3 weeks ago

conico974 commented 1 month ago

When a request does not match any route at all, instead of returning the 404 page it returns a 500. I'm pretty sure it does not happen on every version of next as well, something new that they added at one point. It's an error in the next request handler itself (it tries to pipe to undefined), they must have moved this logic in the server router.

I need to add some e2e test for this as well.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 2c177d22964cd42e509f4fedc13f32bdae3cff9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ---------------- | ----- | | open-next | Patch | | app-pages-router | Patch | | app-router | Patch | | tests-unit | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 4:13pm