sst / open-next

Open source Next.js serverless adapter
https://open-next.js.org
MIT License
3.7k stars 111 forks source link

Fix: await cache set #446

Closed conico974 closed 2 weeks ago

conico974 commented 2 weeks ago

Don't know how this one could have gone undetected, but set is not properly awaited. I'll test this and merge this tomorrow, probably do a release as well. Maybe the latest PR was not even entirely necessary

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 0a5d09cc795e604799a41798aedc40e54ff46777

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 11:32am
conico974 commented 2 weeks ago

Good catch. I wonder if there's a lint that trigger Github to warn like it's warning the missing else clause below. At minimum, it would bring our attention to subtle things like this.

Yeah there is a bunch of them, i thought they was already included to be honest. I'll add them to the eslint config and fix any error that we found here