search

sstaub / Ethernet3

Ethernet library for Arduino and Ethernetshield2 / WIZ550io / WIZ850io / USR-ES1 with Wiznet W5500 chip
Other
76 stars 34 forks source link

Add option for manual SPI transaction control #22

Closed d21d3q closed 6 years ago

d21d3q commented 6 years ago

Fixes this issue with Ethernet2 library. Arafruit doesn't seem to accept PRs so that I am moving to your repository.

sstaub commented 6 years ago

I think that PR is not a good idea, because it seems to be a problem of stm32duino. It will only confuse other users.

d21d3q commented 6 years ago

Not really. After finding out that issue I submitted it to stm32duino, then I started to look for way for solving it and it can't be solved in stm32duino drivers. It is not only problem of stm32duino but probably all non-avr platforms (where setting peripherials is more complex than just writing one register). Why would it confuse users if default configuration is not being affected?

d21d3q commented 6 years ago

@sstaub ?

sstaub commented 6 years ago

I'm not willing to change the code for a problem of a single user. Also, that function breaks the Arduino API. So, the problem must solved at the root. I'm generally not a friend of libraries who makes optimizations for every controller. That is a generally a big problem of the Arduino and other platforms (like ChipKit, Teensy, Ernergia....) community and developers, who are not able to make a working simplified API. Sorry.