search

sstaub / Ethernet3

Ethernet library for Arduino and Ethernetshield2 / WIZ550io / WIZ850io / USR-ES1 with Wiznet W5500 chip
Other
82 stars 33 forks source link

Nit: Ethernet::setHostname could take a const char* #38

Closed jamessynge closed 3 years ago

jamessynge commented 3 years ago

There doesn't seem to be a reason for the string to be non-const, so that would simplify things for the caller.

sstaub commented 3 years ago

You mean changing void setHostname(char* hostname); to void setHostname(const char* hostname);

sstaub commented 3 years ago

Done!

jamessynge commented 3 years ago

Thanks very much.