search

sstephenson / bats

Bash Automated Testing System
MIT License
7.13k stars 517 forks source link

Preserve empty output lines in $lines #93

Open rfletcher opened 9 years ago

rfletcher commented 9 years ago

Empty lines in $output are lost when the $lines array is set. That throws off the expected array index of any lines that follow. This patch preserves those empty lines.

Note that the loop was used to support Bash < 4. Otherwise I would have used the new readarray builtin.

rfletcher commented 9 years ago

Merging this would have the same IFS issue discussed in #90, but I'd hate for you to hold off on a merge for only that reason. If it looks ok otherwise, I could always insert an IFS=$'\n' to preserve the old behavior for now.

ELLIOTTCABLE commented 7 years ago

Is this waiting on something? Is there anything I can do to help this get merged?

(Edit: Also, this probably deserves a mention in the README — this completely and totally breaks $LINES.)

rfletcher commented 7 years ago

Is this waiting on something? Is there anything I can do to help this get merged?

Yes and yes. See discussion in #150.

jasonkarns commented 7 years ago

I believe this has already been resolved with #90 and can be closed?

rfletcher commented 7 years ago

I'm not familiar with issue #90. I think the easiest way to see if that fixes the problem described here is to run this test with #90 applied: https://github.com/rfletcher/bats/blob/1523459bc7e7d934ea5e90d2dfbd8d7fac7ac1cb/test/bats.bats#L266-L273

If it passes, then great! If the [ "${lines[1]}" = "" ] assertion fails, then there's still a problem preserving empty lines. (And the test is worth adding to the build either way, IMO.)

jkroepke commented 3 years ago

We are hitting the problem on bats master (in combination with bats-assert) today.

This issue still exists