"illegal require outside load path" test duplication

sstephenson / sprockets

Rack-based asset packaging system

2.55k stars 24 forks source link

"illegal require outside load path" test duplication #653

Closed obfusk closed 10 years ago

obfusk commented 10 years ago

Hi,

I just noticed that in sprockets/test/test_server.rb, the same test is run twice:

get "/assets/.-0000000./etc/passwd"
assert_equal 403, last_response.status

get "/assets/.-0000000./etc/passwd"
assert_equal 403, last_response.status

Admittedly not a big issue (unless one of those was meant to do something else) ;-)

- Felix

josh commented 10 years ago

Ah, doh, I bet it was a merge conflict.

If you want open a PR to remove it and I'll surely merge it!

obfusk commented 10 years ago

Sure. See #655. I hope there weren't any tests accidentally removed as well.