ssthouse / tree-chart

Flexible tree chart using Canvas and Svg, powered by D3.js; ✅Support Vue, Vue3 and React;
https://ssthouse.github.io/tree-chart/#/svgTree
MIT License
435 stars 96 forks source link

linkStyle prop not used #115

Closed EHadoux closed 2 years ago

EHadoux commented 2 years ago

Hey, thanks again for the Vue3 version. It looks like the linkStyle prop is not used, it always draws curved lines. https://github.com/ssthouse/tree-chart/blob/432c94165192b0befed1240132f8ec3580c1ef89/packages/vue3-tree-chart/src/vue-tree/VueTree.vue#L107-L114 That might be where it's missing. Reverting to 0.1.0 worked though.

ssthouse commented 2 years ago

Hi, sorry for the late reply.

This issue has been fixed in v0.2.5, please check.

kortykotropina commented 2 years ago

Hi! This issue isn't fixed. I fixed it in this PR - https://github.com/ssthouse/tree-chart/pull/121

ssthouse commented 2 years ago

Hi! This issue isn't fixed. I fixed it in this PR - #121

Oh, thank you!

I released your fix in v0.2.6 please check @kortykotropina @EHadoux

EHadoux commented 2 years ago

Yep, seems to be fixed, thanks!