search

sstorie / experiments

A repository to capture simple code experiments
140 stars 205 forks source link

Notification Panel throws errors under ng2 (official release) #10

Closed cdarrigo closed 7 years ago

cdarrigo commented 7 years ago

Assigning animation triggers via @prop="exp" attributes with an expression is invalid. Use property bindings (e.g. [@prop]="exp") or use an attribute without a value (e.g. @prop) instead. ("<div class="container" [ERROR ->]@panelWidthTrigger="expandedState"> <div class="title" @titleColorTrigger="expandedState"> <s"):

sstorie commented 7 years ago

Thanks for submitting the issue @cdarrigo. I will try to make some time to update the code and examples to the current release of Angular 2. I didn't realize how out-of-date it was until I started looking into what you found...!

jhillhouse92 commented 7 years ago

@sstorie any update on this? I'm still experiencing these issues.

sstorie commented 7 years ago

Sorry, no updates on this.

jhillhouse92 commented 7 years ago

:sadpanda: :(... I fixed it locally and will submit a pull request.

jhillhouse92 commented 7 years ago

@sstorie if you are good with pull request, the animated notifications panel can be updated to work.

sstorie commented 7 years ago

Absolutely. Thanks for doing that.