search

sstorie / experiments

A repository to capture simple code experiments
140 stars 205 forks source link

JQuery dependency no in packages or system config? #23

Open ddivita opened 7 years ago

ddivita commented 7 years ago

I don't see JQuery setup as a dependency in the config or packages,json. Also, I do not see how signalr is supposed to be registered in the systemjs.config.js. Am I missing something?

sstorie commented 7 years ago

I assume this is a question about the SignalR work?

ddivita commented 7 years ago

Yes, sorry about that. I didn't realize you had other projects under the same repo.

On Aug 2, 2017 8:51 AM, "Sam Storie" notifications@github.com wrote:

I assume this is a question about the SignalR work?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sstorie/experiments/issues/23#issuecomment-319662640, or mute the thread https://github.com/notifications/unsubscribe-auth/ADRbUseB2N_REzs1lCB7ZAWfENkkTOuuks5sUHDkgaJpZM4OrAdO .

sstorie commented 7 years ago

If memory serves me right, jquery is pulled in as a dependency of the signalr package, and referenced directly from node_modules in index.html.

Does that help at all?

ddivita commented 7 years ago

OK. I guess I was trying to be a purist. I wanted to make sure since in other projects I have had to specifically configure JQuery to run with angular 2 / 4

On Wed, Aug 2, 2017 at 8:58 AM, Sam Storie notifications@github.com wrote:

If memory serves me right, jquery is pulled in as a dependency of the signalr package https://github.com/sstorie/experiments/blob/master/angular2-signalr/client/package.json#L30, and referenced directly from node_modules in index.html https://github.com/sstorie/experiments/blob/master/angular2-signalr/client/index.html#L17 .

Does that help at all?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sstorie/experiments/issues/23#issuecomment-319664314, or mute the thread https://github.com/notifications/unsubscribe-auth/ADRbUkGePMM1WXkfdpaiA77mT5mXQMnqks5sUHJ_gaJpZM4OrAdO .

sstorie commented 7 years ago

Yeah, sorry I know that example hasn't been updated for quite some time.