Improper variable definitions polluting global space

sstrigler / JSJaC

JavaScript Jabber Client Library

Other

295 stars 86 forks source link

Improper variable definitions polluting global space #7

Closed sstrigler closed 12 years ago

sstrigler commented 13 years ago

JavaScript Lint shows quite a few variables that are not being declared with the var keyword, and thus they are polluting the global space, creating the potential for naming collisions and unexpected behavior. Variables include: b64, f64, atob, btoa, attr, attribute, request, query, key, and aArg.

This was checked against code I pulled from github today for jsjac 1.3.2.

rraptorr commented 12 years ago

Some of those problems were fixed in 5e4ba829ee4c3903631b7de14f960b73f705eb71