search

sstrigler / JSJaC

JavaScript Jabber Client Library
Other
295 stars 86 forks source link

Update simpleclient.html #81

Closed sadfuzzy closed 8 years ago

sadfuzzy commented 8 years ago

Remove absent file link

sstrigler commented 8 years ago

Hi, thanks for your contribution. I'm a bit undecided though. The idea is to show how to build a real world client. For this you'd create the "missing" file by doing a make.

../src/JSJaC.js is mostly meant for being used when you'd be developing on JSJaC itself to ease debugging.

15 mars 2016 kl. 17:14 skrev Denis Savitskiy notifications@github.com:

Remove absent file link

You can view, comment on, or merge this pull request online at:

https://github.com/sstrigler/JSJaC/pull/81

Commit Summary

Update simpleclient.html File Changes

M examples/simpleclient.html (5) Patch Links:

https://github.com/sstrigler/JSJaC/pull/81.patch https://github.com/sstrigler/JSJaC/pull/81.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

sadfuzzy commented 8 years ago

It was breaking the app, as I remember

sadfuzzy commented 8 years ago

So I removed the link

sstrigler commented 8 years ago

Not sure how would a comment break the app?

sadfuzzy commented 8 years ago

Line 6 ( ) not comment

sstrigler commented 8 years ago

Oh, yeah, sorry. 🙈

Now I understand. So the thing is, ../jsjac.js is a compiled file. You need to run make in order to get it. But that's the preferred way how to actually use jsjac in real world applications. You don't want to include ../src/JSJaC.js because it loads each single file one by one which results in a lot of unnecessary request and also ../jsjac.js is compressed in contrast to including files from ../src. simpleclient.html is meant to show you how to create a real world application in first place.

Maybe we should add a short note to the README then?

sadfuzzy commented 8 years ago

@sstrigler, got it :) thanks. It will help a lot)