sstsimulator / sst-core

SST Structural Simulation Toolkit Parallel Discrete Event Core and Services
http://www.sst-simulator.org
Other
127 stars 88 forks source link

What is the defined header guard convention in SST? #627

Open nicmcd opened 3 years ago

nicmcd commented 3 years ago

This header guard doesn't match the filename: https://github.com/sstsimulator/sst-core/blob/9ee1db28c6c45129f685179e086739b9d3df83ea/src/sst/core/rng/constant.h#L12

Is there a defined standard? I suggest using clang-tidy during CI to enforce these rules.

feldergast commented 3 years ago

Currently, there are currently no official conventions in the coding standards for header guards. This will be revisited as part of our ongoing work to clean up the core API to better enable broader collaboration. There is currently no timeline for the coding standards updates.