search

sstsimulator / sst-elements

SST Architectural Simulation Components and Libraries
http://www.sst-simulator.org
Other
91 stars 119 forks source link

Ember: Possible error in Ember SpyPlot update method #2004

Open saichennaintel opened 1 year ago

saichennaintel commented 1 year ago

I'm trying to understand the use of ember spyplot feature. Looking at the code, in essence, for each send operation, we are storing the three key details. a. Remote rank to which the current rank is sending the data b. No of times we send to this remote rank c. Total amount of data in bytes send to this remote rank.

However, in https://github.com/sstsimulator/sst-elements/blob/master/src/sst/elements/ember/libs/emberMpiLib.h#L164 , we see that the bytes being added for a send only considers the bytes of the corresponding datatype but not the count. Shouldn't the corresponding line be _sizet bytes = count*api().sizeofDataType(dtype); instead of _sizet bytes = api().sizeofDataType(dtype); ?

feldergast commented 1 year ago

I suspect you're correct. I'll take a look at it.