search

sstsimulator / sst-elements

SST Architectural Simulation Components and Libraries
http://www.sst-simulator.org
Other
93 stars 121 forks source link

mem_nic range check enable/disable and test #2376

Closed kpgriesser closed 4 months ago

kpgriesser commented 4 months ago

This PR adds a new parameter, range_check, to the MemNIC component. Setting this to 0 will disable the memory region overlap check.

A test has been added to memHierarchy/tests called testRangeCheck.py. The test sets the range_check parameter to 0 and should complete very quickly. If the range_check is enabled (or the disable is not working) the test will stall for a very long time and, presumably, be killed by the auto test scripts.

sst-autotester commented 4 months ago

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

kpgriesser commented 4 months ago

Is there a special option or environment variable need to tell sst-test-elements where to find the output for its check? When I run sst-test-elements -e test_memHA_RangeCheck I can see the test output in my local area in sst_test_outputs but the script fails with the message it can't find the file in the sst-elements source are .../src/sst/elements/memHierarhcy/tests/refFiles

gvoskuilen commented 4 months ago

I messed up the test filename in my last comment, the filenames should be: Test: memHierarchy/tests/testRangeCheck.py Ref: memHierarchy/tests/refFiles/test_memHA_RangeCheck.out

The test logic is in testsuite_default_memHierarchy_memHA.py in the function memHA_Template. The template uses the testcase name you pass to it (e.g., "RangeCheck") to identify which files are the test & ref files.

kpgriesser commented 4 months ago

Thanks - should be good to go now. I ran both a passing a failing version of the test to confirm the timeout would fail the test.

sst-autotester commented 4 months ago

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

sst-autotester commented 4 months ago

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

sst-autotester commented 4 months ago

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Build Num: 1489
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_Make-Dist

  • Build Num: 991
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Build Num: 1471
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Build Num: 1469
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 51
  • Status: STARTED
## Using Repos:
Repo: ELEMENTS (kpgriesser/sst-elements-kg)
  • Branch: memnic_setup
  • SHA: 97483bee014f7e14ecf40a4db670f7ab3c97b588
  • Mode: TEST_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: 8511e750279b560b871b00dcdcd418d1a792ecc4
  • Mode: SUPPORT_REPO
Repo: CORE (sstsimulator/sst-core)
  • Branch: devel
  • SHA: a62f11c66eb66e37f9e3571d3a48ad8440fcb58e
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: devel
  • SHA: 4151f95badf1f79d4deb2ebb68984a9fc67d82ca
  • Mode: SUPPORT_REPO
Pull Request Author: kpgriesser

sst-autotester commented 4 months ago

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 4 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Result: PASSED
  • Build #: 1489
  • URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements/1489/consoleFull

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_Make-Dist

  • Result: FAILED
  • Build #: 991
  • URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_Make-Dist/991/consoleFull
  • Job: - Status: FAILURE

Test Results

Test Name Status
test_memHA_RangeCheck FAILED

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Result: PASSED
  • Build #: 1471
  • URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2/1471/consoleFull

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Result: PASSED
  • Build #: 1469
  • URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2/1469/consoleFull

Job: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Result: PASSED
  • Build #: 51
  • URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements/51/consoleFull
gvoskuilen commented 4 months ago

Make-dist failure probably means the new reference & test files are missing from memHierarchy/Makefile.am so they aren't present in the distribution.

kpgriesser commented 4 months ago

I've pushed the change to Makefile.am and attempted to test with:

autogen.sh  
cd build  
make clean && make -j distcheck

This failed with 

ERROR: files left in build directory after distclean:
./src/sst/elements/firefly/pyfirefly.inc
./src/sst/elements/mercury/pymercury.inc
./src/sst/elements/ember/pyember.inc

I don't think this error is related to my edited so I pushed my changes

gvoskuilen commented 4 months ago

You'll also need to add testRangeCheck.py to Makefile.am

And yes, those errors are unrelated. The make-dist test runs the sst test suite on the distribution generated by make dist

sst-autotester commented 4 months ago

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

kpgriesser commented 4 months ago

ok - thanks. 'make dist' appears to pass with the update to Makefile.am.

gvoskuilen commented 4 months ago

Once testRangeCheck.py is added to Makefile.am, we'll get this retested.

kpgriesser commented 4 months ago

done

sst-autotester commented 4 months ago

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

sst-autotester commented 4 months ago

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

sst-autotester commented 4 months ago

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Build Num: 1490
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_Make-Dist

  • Build Num: 992
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Build Num: 1472
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Build Num: 1470
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 52
  • Status: STARTED
## Using Repos:
Repo: ELEMENTS (kpgriesser/sst-elements-kg)
  • Branch: memnic_setup
  • SHA: 0d86d231de2c5a6242a802aec93148b9ce8fd7be
  • Mode: TEST_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: 8511e750279b560b871b00dcdcd418d1a792ecc4
  • Mode: SUPPORT_REPO
Repo: CORE (sstsimulator/sst-core)
  • Branch: devel
  • SHA: a62f11c66eb66e37f9e3571d3a48ad8440fcb58e
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: devel
  • SHA: 4151f95badf1f79d4deb2ebb68984a9fc67d82ca
  • Mode: SUPPORT_REPO
Pull Request Author: kpgriesser

sst-autotester commented 4 months ago

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Build Num: 1490
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_Make-Dist

  • Build Num: 992
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Build Num: 1472
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Build Num: 1470
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 52
  • Status: PASSED
sst-autotester commented 4 months ago

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ gvoskuilen ]!

sst-autotester commented 4 months ago

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

sst-autotester commented 4 months ago

Merge on Pull Request# 2376: IS A SUCCESS - Pull Request successfully merged