search

sstsimulator / sst-elements

SST Architectural Simulation Components and Libraries
http://www.sst-simulator.org
Other
93 stars 121 forks source link

merlin/hr_router: support user-defined portcontrol subcomponents #2424

Open heyitsanthony opened 1 day ago

heyitsanthony commented 1 day ago

For my use-case, I wish to assign bandwidths to local ports different from router-to-router port bandwidths. Although a mechanism exists in hr_router to set heterogeneous port control parameters, it relies on topology logical groups, which is too coarse for assigning properties to local ports (and it's only really used by the dragonfly topology).

This patch checks for user-defined subcomponents on an hr_router's portcontrol slots during initialization and assigns them to the associated port. This is enough to override any port settings by setting the subcomponent on any router after building a topology in pymerlin.

Also includes a small unit-conversion fix for flit_size in portControl that turned up while testing.

sst-autotester commented 1 day ago

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.