search

sstsimulator / sst-macro

SST Macro Element Library
http://sst-simulator.org/
Other
34 stars 41 forks source link

rename and improve null_ptr pragma syntax: Issue #276 #524

Closed jjwilke closed 4 years ago

jjwilke commented 4 years ago

It never made sense to call it null_variable, should always have been `null_ptr

Also gets list of inconsistent syntax for different pragmas

sst-autotester commented 4 years ago

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

sst-autotester commented 4 years ago

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_nosstcore

  • Build Num: 472
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_withsstcore

  • Build Num: 671
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_nosstcore

  • Build Num: 323
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_withsstcore

  • Build Num: 495
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_nosstcore

  • Build Num: 308
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_withsstcore

  • Build Num: 484
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_Make-Dist

  • Build Num: 50
  • Status: STARTED
## Using Repos:
Repo: CORE (sstsimulator/sst-core)
  • Branch: devel
  • SHA: 09444b99c6eca2223cf9802ac448ea307a2efdf7
  • Mode: SUPPORT_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: 64a65c398b2ed46139e73f2a54a48606e681e884
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: change-null-pragma-name-276
  • SHA: 8258ec626d95421b40a9c32af31633a579e7f2b5
  • Mode: TEST_REPO
Repo: ELEMENTS (sstsimulator/sst-elements)
  • Branch: devel
  • SHA: 4b7b8e377ea0db22141e84c75c95c860efcf8ef5
  • Mode: SUPPORT_REPO
Pull Request Author: jjwilke

sst-autotester commented 4 years ago

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_nosstcore

  • Build Num: 472
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_withsstcore

  • Build Num: 671
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_nosstcore

  • Build Num: 323
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_withsstcore

  • Build Num: 495
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_nosstcore

  • Build Num: 308
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_withsstcore

  • Build Num: 484
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_Make-Dist

  • Build Num: 50
  • Status: PASSED
sst-autotester commented 4 years ago

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

sst-autotester commented 4 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester commented 4 years ago

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES

sst-autotester commented 4 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester commented 4 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester commented 4 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

jjwilke commented 4 years ago

PR comments have been addressed. Please approve.

sst-autotester commented 4 years ago

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

sst-autotester commented 4 years ago

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_nosstcore

  • Build Num: 473
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_withsstcore

  • Build Num: 673
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_nosstcore

  • Build Num: 324
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_withsstcore

  • Build Num: 497
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_nosstcore

  • Build Num: 309
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_withsstcore

  • Build Num: 486
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_Make-Dist

  • Build Num: 51
  • Status: STARTED
## Using Repos:
Repo: CORE (sstsimulator/sst-core)
  • Branch: devel
  • SHA: 09444b99c6eca2223cf9802ac448ea307a2efdf7
  • Mode: SUPPORT_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: 64a65c398b2ed46139e73f2a54a48606e681e884
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: change-null-pragma-name-276
  • SHA: c29829faaee492808c277a0303e479dab0578385
  • Mode: TEST_REPO
Repo: ELEMENTS (sstsimulator/sst-elements)
  • Branch: devel
  • SHA: 4b7b8e377ea0db22141e84c75c95c860efcf8ef5
  • Mode: SUPPORT_REPO
Pull Request Author: jjwilke

sst-autotester commented 4 years ago

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_nosstcore

  • Build Num: 473
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_withsstcore

  • Build Num: 673
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_nosstcore

  • Build Num: 324
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_withsstcore

  • Build Num: 497
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_nosstcore

  • Build Num: 309
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_withsstcore

  • Build Num: 486
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_Make-Dist

  • Build Num: 51
  • Status: PASSED
sst-autotester commented 4 years ago

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ calewis ]!

sst-autotester commented 4 years ago

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

sst-autotester commented 4 years ago

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

sst-autotester commented 4 years ago

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_nosstcore

  • Build Num: 475
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_withsstcore

  • Build Num: 675
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_nosstcore

  • Build Num: 326
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_withsstcore

  • Build Num: 499
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_nosstcore

  • Build Num: 311
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_withsstcore

  • Build Num: 488
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_Make-Dist

  • Build Num: 53
  • Status: STARTED
## Using Repos:
Repo: CORE (sstsimulator/sst-core)
  • Branch: devel
  • SHA: 09444b99c6eca2223cf9802ac448ea307a2efdf7
  • Mode: SUPPORT_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: 64a65c398b2ed46139e73f2a54a48606e681e884
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: change-null-pragma-name-276
  • SHA: 5bdc671d46dc0ab5e13b8191dd7c256973b84376
  • Mode: TEST_REPO
Repo: ELEMENTS (sstsimulator/sst-elements)
  • Branch: devel
  • SHA: 4b7b8e377ea0db22141e84c75c95c860efcf8ef5
  • Mode: SUPPORT_REPO
Pull Request Author: jjwilke

sst-autotester commented 4 years ago

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_nosstcore

  • Build Num: 475
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_withsstcore

  • Build Num: 675
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_nosstcore

  • Build Num: 326
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-macro_withsstcore

  • Build Num: 499
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_nosstcore

  • Build Num: 311
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_Ubuntu_sst-macro_withsstcore

  • Build Num: 488
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-macro_Make-Dist

  • Build Num: 53
  • Status: PASSED
sst-autotester commented 4 years ago

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

sst-autotester commented 4 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester commented 4 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester commented 4 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester commented 4 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...