search

sstsimulator / sst-macro

SST Macro Element Library
http://sst-simulator.org/
Other
34 stars 41 forks source link

Fix parallel simulation on sst-core #627

Closed jpkenny closed 3 years ago

jpkenny commented 3 years ago

Fixes to support parallel simulation on sst-core.

sst-autotester commented 3 years ago

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

sst-autotester commented 3 years ago

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-10.14-XC11_OMPI-4.0.5_PY3.8_sst-macro_nosstcore

  • Build Num: 53
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-10.14-XC11_OMPI-4.0.5_PY3.8_sst-macro_withsstcore

  • Build Num: 168
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY2.7_sst-macro_nosstcore

  • Build Num: 53
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY2.7_sst-macro_withsstcore

  • Build Num: 168
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_Make-Dist

  • Build Num: 52
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_nosstcore

  • Build Num: 59
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_withsstcore

  • Build Num: 195
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_Ubuntu-18.04_OMPI-4.0.5_PY3.6_sst-macro_nosstcore

  • Build Num: 52
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_Ubuntu-18.04_OMPI-4.0.5_PY3.6_sst-macro_withsstcore

  • Build Num: 168
  • Status: STARTED
## Using Repos:
Repo: MACRO (jpkenny/sst-macro)
  • Branch: fix-logp
  • SHA: 16eb752ff22969796b856f2b6e70b302cb6fbf84
  • Mode: TEST_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: 2cb58cd17d5fb3e5f9beb375f8e14ae776c12da5
  • Mode: SUPPORT_REPO
Repo: ELEMENTS (sstsimulator/sst-elements)
  • Branch: devel
  • SHA: ea8e0e2399695b6a9c7308b7cf4ce233af627766
  • Mode: SUPPORT_REPO
Repo: CORE (sstsimulator/sst-core)
  • Branch: devel
  • SHA: 361995e23f5f58493f7dfd59bd13f1cdd23bebe2
  • Mode: SUPPORT_REPO
Pull Request Author: jpkenny

sst-autotester commented 3 years ago

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-10.14-XC11_OMPI-4.0.5_PY3.8_sst-macro_nosstcore

  • Build Num: 53
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-10.14-XC11_OMPI-4.0.5_PY3.8_sst-macro_withsstcore

  • Build Num: 168
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY2.7_sst-macro_nosstcore

  • Build Num: 53
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY2.7_sst-macro_withsstcore

  • Build Num: 168
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_Make-Dist

  • Build Num: 52
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_nosstcore

  • Build Num: 59
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_withsstcore

  • Build Num: 195
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_Ubuntu-18.04_OMPI-4.0.5_PY3.6_sst-macro_nosstcore

  • Build Num: 52
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_Ubuntu-18.04_OMPI-4.0.5_PY3.6_sst-macro_withsstcore

  • Build Num: 168
  • Status: PASSED
sst-autotester commented 3 years ago

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

sst-autotester commented 3 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester commented 3 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester commented 3 years ago

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES

sst-autotester commented 3 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

calewis commented 3 years ago

I think everything left unresolved is what needs to change.

sst-autotester commented 3 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester commented 3 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

jpkenny commented 3 years ago

I think everything left unresolved is what needs to change.

I have addressed all unresolved review conversations in cs 5841f71.

sst-autotester commented 3 years ago

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

sst-autotester commented 3 years ago

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-10.14-XC11_OMPI-4.0.5_PY3.8_sst-macro_nosstcore

  • Build Num: 54
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-10.14-XC11_OMPI-4.0.5_PY3.8_sst-macro_withsstcore

  • Build Num: 169
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY2.7_sst-macro_nosstcore

  • Build Num: 54
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY2.7_sst-macro_withsstcore

  • Build Num: 169
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_Make-Dist

  • Build Num: 53
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_nosstcore

  • Build Num: 60
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_withsstcore

  • Build Num: 196
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_Ubuntu-18.04_OMPI-4.0.5_PY3.6_sst-macro_nosstcore

  • Build Num: 53
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_Ubuntu-18.04_OMPI-4.0.5_PY3.6_sst-macro_withsstcore

  • Build Num: 169
  • Status: STARTED
## Using Repos:
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: 2cb58cd17d5fb3e5f9beb375f8e14ae776c12da5
  • Mode: SUPPORT_REPO
Repo: MACRO (jpkenny/sst-macro)
  • Branch: fix-logp
  • SHA: 5841f71171af9aec72e96ab5c05172707dfda6b0
  • Mode: TEST_REPO
Repo: ELEMENTS (sstsimulator/sst-elements)
  • Branch: devel
  • SHA: ea8e0e2399695b6a9c7308b7cf4ce233af627766
  • Mode: SUPPORT_REPO
Repo: CORE (sstsimulator/sst-core)
  • Branch: devel
  • SHA: 361995e23f5f58493f7dfd59bd13f1cdd23bebe2
  • Mode: SUPPORT_REPO
Pull Request Author: jpkenny

sst-autotester commented 3 years ago

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-10.14-XC11_OMPI-4.0.5_PY3.8_sst-macro_nosstcore

  • Build Num: 54
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-10.14-XC11_OMPI-4.0.5_PY3.8_sst-macro_withsstcore

  • Build Num: 169
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY2.7_sst-macro_nosstcore

  • Build Num: 54
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY2.7_sst-macro_withsstcore

  • Build Num: 169
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_Make-Dist

  • Build Num: 53
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_nosstcore

  • Build Num: 60
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.8_sst-macro_withsstcore

  • Build Num: 196
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_Ubuntu-18.04_OMPI-4.0.5_PY3.6_sst-macro_nosstcore

  • Build Num: 53
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_Ubuntu-18.04_OMPI-4.0.5_PY3.6_sst-macro_withsstcore

  • Build Num: 169
  • Status: PASSED
sst-autotester commented 3 years ago

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES

sst-autotester commented 3 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester commented 3 years ago

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

calewis commented 3 years ago

How do we trigger Pre-Merge inspection?

sst-autotester commented 3 years ago

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ calewis ]!

sst-autotester commented 3 years ago

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

jpkenny commented 3 years ago

How do we trigger Pre-Merge inspection?

I don't think we do anything, it just changes to the correct status (when the there's a review approval?).

calewis commented 3 years ago

Looks like it took about an hour. I guess autotester doesn't poll things that often or something.

zbluex commented 2 years ago

Fixes to support parallel simulation on sst-core.

  • LogP short-circuit network uses single-switch star topology instead of one switch per simulation rank. This is much cleaner but is a potential performance degradation.
  • "macro.block" partitioner is not currently working. I'm not sure if it was ever tested. Disabled in this PR and I will file an issue for it.

@jpkenny hi，We found that when logP was changed to a single instance, concurrent execution performance was affected. I want to know why THE logp switch was changed to a single instance. Is it for functional reasons or is there a flaw that has to be changed to a single instance?