Closed jpkenny closed 3 years ago
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...
I think everything left unresolved is what needs to change.
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...
I think everything left unresolved is what needs to change.
I have addressed all unresolved review conversations in cs 5841f71.
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...
How do we trigger Pre-Merge inspection?
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ calewis ]!
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge
How do we trigger Pre-Merge inspection?
I don't think we do anything, it just changes to the correct status (when the there's a review approval?).
Looks like it took about an hour. I guess autotester doesn't poll things that often or something.
Fixes to support parallel simulation on sst-core.
- LogP short-circuit network uses single-switch star topology instead of one switch per simulation rank. This is much cleaner but is a potential performance degradation.
- "macro.block" partitioner is not currently working. I'm not sure if it was ever tested. Disabled in this PR and I will file an issue for it.
@jpkenny hi,We found that when logP was changed to a single instance, concurrent execution performance was affected. I want to know why THE logp switch was changed to a single instance. Is it for functional reasons or is there a flaw that has to be changed to a single instance?
Fixes to support parallel simulation on sst-core.